unpin openpyxl #23361
unpin openpyxl #23361
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23361 +/- ##
=======================================
Coverage 92.18% 92.18%
=======================================
Files 161 161
Lines 51155 51155
=======================================
Hits 47157 47157
Misses 3998 3998
Continue to review full report at Codecov.
|
gfyoung
added
Build
ci/azure-27-compat.yaml
Outdated
| @@ -8,7 +8,7 @@ dependencies: | |||
| - jinja2=2.8 | |||
| - numexpr=2.6.1 | |||
| - numpy=1.12.0 | |||
| - openpyxl=2.5.5 | |||
There was a problem hiding this comment.
can you leave this pin here
|
thanks @alimcmaster1 |
|
@jreback this is strange - this seems to have gone green on Azure despite the fact https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=2029&view=ms.vss-test-web.test-result-details tests seem to be failing on MacOS-35, or am I missing something? Previous commit to master has no mention of these test failures so my commit looks to be the suspect. This seems to be related: Do we want to fail the build if tests fail ( i'm guessing yes ) current behaviour seems to be no? |
|
@TomAugspurger thought I would also bring my above comment to your attention. Do you want me to create an issue? Pretty sure we want azure pipeline to fail if tests fail? |
|
Yeah, we want the CI status to be failed when the tests fails. Skimming microsoft/azure-pipelines-tasks#1268 didn't make sense to me. I suppose we could only publish tests results if there's not a failure? |
passes
git diff upstream/master -u -- "*.py" | flake8 --diffFollow up from BLD: Fix openpyxl to 2.5.5 #22601.
Confirmed with openpyxl this bug was fixed in version 2.5.7 see bitbucket issue here
This was release 13th Sept -> https://pypi.org/project/openpyxl/#history